Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 60908855 authored by Johan Hovold's avatar Johan Hovold Committed by Samuel Ortiz
Browse files

mfd: Fix return type of lm533 attribute is_visible 



Since commit 587a1f16 ("switch ->is_visible() to returning umode_t")
the return type of is_visible is umode_t rather than mode_t.

This silences a compiler warning on some architectures where these types
are not compatible.

Reported-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarJohan Hovold <jhovold@gmail.com>
Signed-off-by: default avatarSamuel Ortiz <sameo@linux.intel.com>
parent 3770c75a

drivers/mfd/lm3533-core.c

+1 −1
Original line number Diff line number Diff line
@@ -367,7 +367,7 @@ static umode_t lm3533_attr_is_visible(struct kobject *kobj, 
	struct device_attribute *dattr = to_dev_attr(attr);

	struct lm3533_device_attribute *lattr = to_lm3533_dev_attr(dattr);

	enum lm3533_attribute_type type = lattr->type;

	mode_t mode = attr->mode;

	umode_t mode = attr->mode;



	if (!lm3533->have_backlights && type == LM3533_ATTR_TYPE_BACKLIGHT)

		mode = 0;