Commit 607954b0 authored Jan 21, 2015 by Patrick McHardy Committed by David S. Miller Jan 26, 2015

rhashtable: fix rht_for_each_entry_safe() endless loop



"next" is not updated, causing an endless loop for buckets with more than
one element.

Fixes: 88d6ed15 ("rhashtable: Convert bucket iterators to take table and index")
Signed-off-by: Patrick McHardy <kaber@trash.net>
Acked-by: Thomas Graf <tgraf@suug.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 22f6bba7

include/linux/rhashtable.h

+3 −1

Original line number	Diff line number	Diff line
		@@ -260,7 +260,9 @@ void rhashtable_destroy(struct rhashtable *ht);
		next = !rht_is_a_nulls(pos) ? \
		rht_dereference_bucket(pos->next, tbl, hash) : NULL; \
		(!rht_is_a_nulls(pos)) && rht_entry(tpos, pos, member); \
		pos = next)
		pos = next, \
		next = !rht_is_a_nulls(pos) ? \
		rht_dereference_bucket(pos->next, tbl, hash) : NULL)

		/**
		* rht_for_each_rcu_continue - continue iterating over rcu hash chain