Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6032df37 authored by Colin Ian King's avatar Colin Ian King Committed by Greg Kroah-Hartman
Browse files

drm/amdgpu: fix uninitialized variable pasid_mapping_needed 



[ Upstream commit 17cf678a33c6196a3df4531fe5aec91384c9eeb5 ]

The boolean variable pasid_mapping_needed is not initialized and
there are code paths that do not assign it any value before it is
is read later.  Fix this by initializing pasid_mapping_needed to
false.

Addresses-Coverity: ("Uninitialized scalar variable")
Fixes: 6817bf283b2b ("drm/amdgpu: grab the id mgr lock while accessing passid_mapping")
Reviewed-by: default avatarChristian König <christian.koenig@amd.com>
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 21b23e95

drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c

+1 −1
Original line number Diff line number Diff line
@@ -701,7 +701,7 @@ int amdgpu_vm_flush(struct amdgpu_ring *ring, struct amdgpu_job *job, bool need_ 
		id->oa_size != job->oa_size);

	bool vm_flush_needed = job->vm_needs_flush;

	struct dma_fence *fence = NULL;

	bool pasid_mapping_needed;

	bool pasid_mapping_needed = false;

	unsigned patch_offset = 0;

	int r;