Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5ff22646 authored by Peter Zijlstra's avatar Peter Zijlstra Committed by Jessica Yu
Browse files

module: Optimize search_module_extables() 



While looking through the __ex_table stuff I found that we do a linear
lookup of the module. Also fix up a comment.

Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: default avatarMark Rutland <mark.rutland@arm.com>
Signed-off-by: default avatarJessica Yu <jeyu@redhat.com>
parent 1f318a8b

kernel/module.c

+14 −13
Original line number Diff line number Diff line
@@ -4170,22 +4170,23 @@ const struct exception_table_entry *search_module_extables(unsigned long addr) 
	struct module *mod;



	preempt_disable();

	list_for_each_entry_rcu(mod, &modules, list) {

		if (mod->state == MODULE_STATE_UNFORMED)

			continue;

		if (mod->num_exentries == 0)

			continue;

	mod = __module_address(addr);

	if (!mod)

		goto out;



	if (!mod->num_exentries)

		goto out;



	e = search_extable(mod->extable,

			   mod->extable + mod->num_exentries - 1,

			   addr);

		if (e)

			break;

	}

out:

	preempt_enable();



	/* Now, if we found one, we are running inside it now, hence

	   we cannot unload the module, hence no refcnt needed. */

	/*

	 * Now, if we found one, we are running inside it now, hence

	 * we cannot unload the module, hence no refcnt needed.

	 */

	return e;

}