Commit 5fc6e73b authored Mar 31, 2021 by Ewan D. Milne Committed by Greg Kroah-Hartman May 22, 2021

scsi: scsi_dh_alua: Remove check for ASC 24h in alua_rtpg()

[ Upstream commit bc3f2b42b70eb1b8576e753e7d0e117bbb674496 ]

Some arrays return ILLEGAL_REQUEST with ASC 00h if they don't support the
RTPG extended header so remove the check for INVALID FIELD IN CDB.

Link: https://lore.kernel.org/r/20210331201154.20348-1-emilne@redhat.com


Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Ewan D. Milne <emilne@redhat.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 1218baa3

drivers/scsi/device_handler/scsi_dh_alua.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -579,10 +579,11 @@ static int alua_rtpg(struct scsi_device sdev, struct alua_port_group pg)
		* even though it shouldn't according to T10.
		* The retry without rtpg_ext_hdr_req set
		* handles this.
		* Note: some arrays return a sense key of ILLEGAL_REQUEST
		* with ASC 00h if they don't support the extended header.
		*/
		if (!(pg->flags & ALUA_RTPG_EXT_HDR_UNSUPP) &&
		sense_hdr.sense_key == ILLEGAL_REQUEST &&
		sense_hdr.asc == 0x24 && sense_hdr.ascq == 0) {
		sense_hdr.sense_key == ILLEGAL_REQUEST) {
		pg->flags \|= ALUA_RTPG_EXT_HDR_UNSUPP;
		goto retry;
		}