Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5e6db669 authored by Gabriele Mazzotta's avatar Gabriele Mazzotta Committed by Takashi Iwai
Browse files

ALSA: hda - White noise fix for XPS13 9333 



Disable the AA-loopback path to get rid of the constant white noise
that can be heard when headphones are used.

Signed-off-by: default avatarGabriele Mazzotta <gabriele.mzt@gmail.com>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent f73387cb

sound/pci/hda/patch_realtek.c

+18 −1
Original line number Diff line number Diff line
@@ -3970,6 +3970,16 @@ static void alc_fixup_no_shutup(struct hda_codec *codec, 
	}

}



static void alc_fixup_disable_aamix(struct hda_codec *codec,

				    const struct hda_fixup *fix, int action)

{

	if (action == HDA_FIXUP_ACT_PRE_PROBE) {

		struct alc_spec *spec = codec->spec;

		/* Disable AA-loopback as it causes white noise */

		spec->gen.mixer_nid = 0;

	}

}



static void alc_fixup_headset_mode_alc668(struct hda_codec *codec,

				const struct hda_fixup *fix, int action)

{
@@ -5414,6 +5424,7 @@ enum { 
	ALC662_FIXUP_BASS_1A,

	ALC662_FIXUP_BASS_CHMAP,

	ALC668_FIXUP_AUTO_MUTE,

	ALC668_FIXUP_DELL_DISABLE_AAMIX,

};



static const struct hda_fixup alc662_fixups[] = {
@@ -5580,6 +5591,12 @@ static const struct hda_fixup alc662_fixups[] = { 
		.type = HDA_FIXUP_FUNC,

		.v.func = alc_fixup_inv_dmic_0x12,

	},

	[ALC668_FIXUP_DELL_DISABLE_AAMIX] = {

		.type = HDA_FIXUP_FUNC,

		.v.func = alc_fixup_disable_aamix,

		.chained = true,

		.chain_id = ALC668_FIXUP_DELL_MIC_NO_PRESENCE

	},

	[ALC668_FIXUP_AUTO_MUTE] = {

		.type = HDA_FIXUP_FUNC,

		.v.func = alc_fixup_auto_mute_via_amp,
@@ -5640,7 +5657,7 @@ static const struct snd_pci_quirk alc662_fixup_tbl[] = { 
	SND_PCI_QUIRK(0x1025, 0x038b, "Acer Aspire 8943G", ALC662_FIXUP_ASPIRE),

	SND_PCI_QUIRK(0x1028, 0x05d8, "Dell", ALC668_FIXUP_DELL_MIC_NO_PRESENCE),

	SND_PCI_QUIRK(0x1028, 0x05db, "Dell", ALC668_FIXUP_DELL_MIC_NO_PRESENCE),

	SND_PCI_QUIRK(0x1028, 0x060a, "Dell XPS 13", ALC668_FIXUP_DELL_MIC_NO_PRESENCE),

	SND_PCI_QUIRK(0x1028, 0x060a, "Dell XPS 13", ALC668_FIXUP_DELL_DISABLE_AAMIX),

	SND_PCI_QUIRK(0x1028, 0x0623, "Dell", ALC668_FIXUP_AUTO_MUTE),

	SND_PCI_QUIRK(0x1028, 0x0624, "Dell", ALC668_FIXUP_AUTO_MUTE),

	SND_PCI_QUIRK(0x1028, 0x0625, "Dell", ALC668_FIXUP_DELL_MIC_NO_PRESENCE),