Commit 5e4cf2bf authored Mar 23, 2018 by Dan Carpenter Committed by Steven Rostedt (VMware) Mar 23, 2018

tracing: Fix a potential NULL dereference

We forgot to set the error code on this path so we return ERR_PTR(0)
which is NULL. It results in a NULL dereference in the caller.

Link: http://lkml.kernel.org/r/20180323113735.GC28518@mwanda

Fixes: 100719dc ("tracing: Add simple expression support to hist triggers")
Acked-by: Tom Zanussi <tom.zanussi@linux.intel.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

parent 80765597

kernel/trace/trace_events_hist.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -2776,6 +2776,7 @@ static struct hist_field parse_expr(struct hist_trigger_data hist_data,
		expr->fn = hist_field_plus;
		break;
		default:
		ret = -EINVAL;
		goto free;
		}