Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5dc4f34a authored by Gurram Pravalika's avatar Gurram Pravalika Committed by Gerrit - the friendly Code Review server
Browse files

msm: camera: Fix for memory leak 



freeing memory while returning from function.

Change-Id: I571d6cdd92fb843b47100dd0d3d0f988dd678b2c
Signed-off-by: default avatarGurram Pravalika <gpravali@codeaurora.org>
parent bed17f6d

drivers/media/platform/msm/camera_v2/isp/msm_isp_util.c

+4 −1
Original line number Diff line number Diff line
@@ -1544,8 +1544,10 @@ int msm_isp_proc_cmd(struct vfe_device *vfe_dev, void *arg) 
			proc_cmd->cmd_len <= UINT16_MAX) {

		cfg_data = memdup_user((void __user *)(proc_cmd->cfg_data),

			proc_cmd->cmd_len);

		if (IS_ERR(cfg_data))

		if (IS_ERR(cfg_data)) {

			kfree(reg_cfg_cmd);

			return PTR_ERR(cfg_data);

		}

	} else {

		pr_debug("%s: Passed cmd_len as 0\n", __func__);

	}
@@ -1562,6 +1564,7 @@ int msm_isp_proc_cmd(struct vfe_device *vfe_dev, void *arg) 
copy_cmd_failed:

	kfree(cfg_data);

reg_cfg_failed:

	kfree(reg_cfg_cmd);

	return rc;

}