Commit 5dbe4433 authored Jan 13, 2015 by Laurent Pinchart

drm: omapdrm: Fix race condition between GO and vblank IRQ



The vblank interrupt is used by the driver as a completion signal when
applying new settings.

A race condition exist between enabling the vblank interrupt and
applying new settings to the hardware by setting the GO bit. If a vblank
interrupt occurs in-between, the driver will incorrectly consider the
new settings to be applied. Fix this by enabling the interrupt after
setting the GO bit.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

parent 82e58855

drivers/gpu/drm/omapdrm/omap_crtc.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -501,8 +501,8 @@ static void apply_worker(struct work_struct *work)
		DBG("%s: GO", omap_crtc->name);

		if (dispc_mgr_is_enabled(channel)) {
		omap_irq_register(dev, &omap_crtc->apply_irq);
		dispc_mgr_go(channel);
		omap_irq_register(dev, &omap_crtc->apply_irq);
		} else {
		struct omap_drm_private *priv = dev->dev_private;
		queue_work(priv->wq, &omap_crtc->apply_work);