Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5d304400 authored by Ben Dooks's avatar Ben Dooks Committed by Pierre Ossman
Browse files

s3cmci: fix sparse errors from non-exported functions 



Fix the following sparse errors by making the functions
static and fixing the check for host->base.

598:6: warning: symbol 's3cmci_dma_done_callback' was not declared. Should it be static?
744:6: warning: symbol 's3cmci_dma_setup' was not declared. Should it be static?
1209:20: warning: Using plain integer as NULL pointer

Signed-off-by: default avatarBen Dooks <ben-linux@fluff.org>
Signed-off-by: default avatarPierre Ossman <drzeus@drzeus.cx>
parent b09c3e3f

drivers/mmc/host/s3cmci.c

+6 −5
Original line number Diff line number Diff line
@@ -595,8 +595,9 @@ static irqreturn_t s3cmci_irq_cd(int irq, void *dev_id) 
	return IRQ_HANDLED;

}



void s3cmci_dma_done_callback(struct s3c2410_dma_chan *dma_ch, void *buf_id,

			      int size, enum s3c2410_dma_buffresult result)

static void s3cmci_dma_done_callback(struct s3c2410_dma_chan *dma_ch,

				     void *buf_id, int size,

				     enum s3c2410_dma_buffresult result)

{

	struct s3cmci_host *host = buf_id;

	unsigned long iflags;
@@ -740,8 +741,8 @@ static void finalize_request(struct s3cmci_host *host) 
	mmc_request_done(host->mmc, mrq);

}





void s3cmci_dma_setup(struct s3cmci_host *host, enum s3c2410_dmasrc source)

static void s3cmci_dma_setup(struct s3cmci_host *host,

			     enum s3c2410_dmasrc source)

{

	static enum s3c2410_dmasrc last_source = -1;

	static int setup_ok;
@@ -1206,7 +1207,7 @@ static int __devinit s3cmci_probe(struct platform_device *pdev, int is2440) 
	}



	host->base = ioremap(host->mem->start, RESSIZE(host->mem));

	if (host->base == 0) {

	if (!host->base) {

		dev_err(&pdev->dev, "failed to ioremap() io memory region.\n");

		ret = -EINVAL;

		goto probe_free_mem_region;