Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5d1c2a9b authored by Peter Huewe's avatar Peter Huewe Committed by Greg Kroah-Hartman
Browse files

staging/xgifb: Remove unnecessary bitshifts in XGI_SetCRT1ModeRegs 



Since data can only be 0x0000, 0x0035 or 0x0048 we can simply skip the
bit shifting and masking as data & 0xFF is always equal to data and
data & 0xFF00 is always 0.
So we simply use data and 0 directly and save the assignment.

Signed-off-by: default avatarPeter Huewe <peterhuewe@gmx.de>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent a5e080b8

drivers/staging/xgifb/vb_setmode.c

+2 −4
Original line number Diff line number Diff line
@@ -1083,10 +1083,8 @@ static void XGI_SetCRT1ModeRegs(struct xgi_hw_device_info *HwDeviceExtension, 
			data = 0x0048;

	}



	data2 = data & 0x00FF;

	xgifb_reg_and_or(pVBInfo->P3d4, 0x19, 0xFF, data2);

	data2 = (data & 0xFF00) >> 8;

	xgifb_reg_and_or(pVBInfo->P3d4, 0x19, 0xFC, data2);

	xgifb_reg_and_or(pVBInfo->P3d4, 0x19, 0xFF, data);

	xgifb_reg_and_or(pVBInfo->P3d4, 0x19, 0xFC, 0);



	if (modeflag & HalfDCLK)

		xgifb_reg_and_or(pVBInfo->P3c4, 0x01, 0xF7, 0x08);