Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5cce428d authored by Chuck Lever's avatar Chuck Lever Committed by Trond Myklebust
Browse files

NFS: Remove an unneeded check in decode_compound_header_arg() 



Clean up:  The header tag length is unsigned, so checking that it is less
than zero is unnecessary.

Signed-off-by: default avatarChuck Lever <chuck.lever@oracle.com>
Signed-off-by: default avatarTrond Myklebust <Trond.Myklebust@netapp.com>
parent d45273ed

fs/nfs/callback_xdr.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -139,7 +139,7 @@ static __be32 decode_compound_hdr_arg(struct xdr_stream *xdr, struct cb_compound 
	if (unlikely(status != 0))

	if (unlikely(status != 0))

		return status;

		return status;

	/* We do not like overly long tags! */

	/* We do not like overly long tags! */

	if (hdr->taglen > CB_OP_TAGLEN_MAXSZ-12 || hdr->taglen < 0) {

	if (hdr->taglen > CB_OP_TAGLEN_MAXSZ - 12) {

		printk("NFSv4 CALLBACK %s: client sent tag of length %u\n",

		printk("NFSv4 CALLBACK %s: client sent tag of length %u\n",

				__FUNCTION__, hdr->taglen);

				__FUNCTION__, hdr->taglen);

		return htonl(NFS4ERR_RESOURCE);

		return htonl(NFS4ERR_RESOURCE);