Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5ca3353b authored by Linus Walleij's avatar Linus Walleij
Browse files

pinctrl: establish pull-up/pull-down terminology 



It is counter-intuitive to have "0" mean disable in a boolean
manner for electronic properties of pins such as pull-up and
pull-down. Therefore, define that a pull-up/pull-down argument
of 0 to such a generic option means that the pin is
short-circuited to VDD or GROUND. Pull disablement shall be
done using PIN_CONFIG_BIAS_DISABLE.

Cc: James Hogan <james.hogan@imgtec.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by Heiko Stuebner <heiko@sntech.de>
Acked-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 6abab2d4

include/linux/pinctrl/pinconf-generic.h

+7 −6
Original line number Diff line number Diff line
@@ -36,14 +36,15 @@ 
 *	tristate. The argument is ignored.

 * @PIN_CONFIG_BIAS_PULL_UP: the pin will be pulled up (usually with high

 *	impedance to VDD). If the argument is != 0 pull-up is enabled,

 *	if it is 0, pull-up is disabled.

 *	if it is 0, pull-up is total, i.e. the pin is connected to VDD.

 * @PIN_CONFIG_BIAS_PULL_DOWN: the pin will be pulled down (usually with high

 *	impedance to GROUND). If the argument is != 0 pull-down is enabled,

 *	if it is 0, pull-down is disabled.

 *	if it is 0, pull-down is total, i.e. the pin is connected to GROUND.

 * @PIN_CONFIG_BIAS_PULL_PIN_DEFAULT: the pin will be pulled up or down based

 *	on embedded knowledge of the controller, like current mux function.

 *	If the argument is != 0 pull up/down is enabled, if it is 0,

 *	the pull is disabled.

 *	If the argument is != 0 pull up/down is enabled, if it is 0, the

 *	configuration is ignored. The proper way to disable it is to use

 *	@PIN_CONFIG_BIAS_DISABLE.

 * @PIN_CONFIG_DRIVE_PUSH_PULL: the pin will be driven actively high and

 *	low, this is the most typical case and is typically achieved with two

 *	active transistors on the output. Setting this config will enable