Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5c66d939 authored by NeilBrown's avatar NeilBrown Committed by Martin K. Petersen
Browse files

scsi: ibmvfc: don't check for failure from mempool_alloc() 



mempool_alloc() cannot fail when passed GFP_NOIO or any other gfp
setting that is permitted to sleep.  So remove this pointless code.

Signed-off-by: default avatarNeilBrown <neilb@suse.com>
Acked-by: default avatarTyrel Datwyler <tyreld@linux.vnet.ibm.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 8d4208c1

drivers/scsi/ibmvscsi/ibmvfc.c

+0 −6
Original line number Original line Diff line number Diff line
@@ -3910,12 +3910,6 @@ static int ibmvfc_alloc_target(struct ibmvfc_host *vhost, u64 scsi_id) 
	spin_unlock_irqrestore(vhost->host->host_lock, flags);

	spin_unlock_irqrestore(vhost->host->host_lock, flags);





	tgt = mempool_alloc(vhost->tgt_pool, GFP_NOIO);

	tgt = mempool_alloc(vhost->tgt_pool, GFP_NOIO);

	if (!tgt) {

		dev_err(vhost->dev, "Target allocation failure for scsi id %08llx\n",

			scsi_id);

		return -ENOMEM;

	}



	memset(tgt, 0, sizeof(*tgt));

	memset(tgt, 0, sizeof(*tgt));

	tgt->scsi_id = scsi_id;

	tgt->scsi_id = scsi_id;

	tgt->new_scsi_id = scsi_id;

	tgt->new_scsi_id = scsi_id;