Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5c11581d authored by Li Nan's avatar Li Nan Committed by Greg Kroah-Hartman
Browse files

md: clean up invalid BUG_ON in md_ioctl 



[ Upstream commit 9dd8702e7cd28ebf076ff838933f29cf671165ec ]

'disk->private_data' is set to mddev in md_alloc() and never set to NULL,
and users need to open mddev before submitting ioctl. So mddev must not
have been freed during ioctl, and there is no need to check mddev here.
Clean up it.

Signed-off-by: default avatarLi Nan <linan122@huawei.com>
Reviewed-by: default avatarYu Kuai <yukuai3@huawei.com>
Signed-off-by: default avatarSong Liu <song@kernel.org>
Link: https://lore.kernel.org/r/20240226031444.3606764-4-linan666@huaweicloud.com


Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 7783533f

drivers/md/md.c

+0 −5
Original line number Diff line number Diff line
@@ -7245,11 +7245,6 @@ static int md_ioctl(struct block_device *bdev, fmode_t mode, 


	mddev = bdev->bd_disk->private_data;



	if (!mddev) {

		BUG();

		goto out;

	}



	/* Some actions do not requires the mutex */

	switch (cmd) {

	case GET_ARRAY_INFO: