Commit 5c0ba577 authored Oct 25, 2016 by Arnd Bergmann Committed by Mark Brown Oct 26, 2016

spi: fsl-espi: avoid processing uninitalized data on error



When we get a spurious interrupt in fsl_espi_irq, we end up
processing four uninitalized bytes of data, as shown in this
warning message:

   drivers/spi/spi-fsl-espi.c: In function 'fsl_espi_irq':
   drivers/spi/spi-fsl-espi.c:462:4: warning: 'rx_data' may be used uninitialized in this function [-Wmaybe-uninitialized]

This adds another check so we skip the data in this case.

Fixes: 6319a680 ("spi/fsl-espi: avoid infinite loops on fsl_espi_cpu_irq()")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Mark Brown <broonie@kernel.org>
Cc: stable@vger.kernel.org

parent 1001354c

drivers/spi/spi-fsl-espi.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -458,7 +458,7 @@ static void fsl_espi_cpu_irq(struct mpc8xxx_spi *mspi, u32 events)

		mspi->len -= rx_nr_bytes;

		if (mspi->rx)
		if (rx_nr_bytes && mspi->rx)
		mspi->get_rx(rx_data, mspi);
		}