Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5b9fc795 authored by Denis Osterland's avatar Denis Osterland Committed by Alexandre Belloni
Browse files

rtc: isl1208: Fix unintended clear of SR bits 



After successful
sr = isl1208_i2c_set_regs(client, 0, regs, ISL1208_RTC_SECTION_LEN);
sr will be 0.
As a result
sr = i2c_smbus_write_byte_data(client, ISL1208_REG_SR,
			sr & ~ISL1208_REG_SR_WRTC);
is equal to
sr = i2c_smbus_write_byte_data(client, ISL1208_REG_SR, 0);
which clears all flags in SR.

Add an additional read of SR, to have value of SR in sr again.

Signed-off-by: default avatarDenis Osterland <Denis.Osterland@diehl.com>
Signed-off-by: default avatarMichael Grzeschik <m.grzeschik@pengutronix.de>
Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
parent dd888c61

drivers/rtc/rtc-isl1208.c

+5 −0
Original line number Diff line number Diff line
@@ -459,6 +459,11 @@ isl1208_i2c_set_time(struct i2c_client *client, struct rtc_time const *tm) 
	}



	/* clear WRTC again */

	sr = isl1208_i2c_get_sr(client);

	if (sr < 0) {

		dev_err(&client->dev, "%s: reading SR failed\n", __func__);

		return sr;

	}

	sr = i2c_smbus_write_byte_data(client, ISL1208_REG_SR,

				       sr & ~ISL1208_REG_SR_WRTC);

	if (sr < 0) {