Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5b4d10f5 authored by Dan Carpenter's avatar Dan Carpenter Committed by David S. Miller
Browse files

qlcnic: use the correct ring in qlcnic_83xx_process_rcv_ring_diag() 



There is a static checker warning here "warn: mask and shift to zero"
and the code sets "ring" to zero every time.  From looking at how
QLCNIC_FETCH_RING_ID() is used in qlcnic_83xx_process_rcv_ring() the
qlcnic_83xx_hndl() should be removed.

Fixes: 4be41e92 ('qlcnic: 83xx data path routines')
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent ceb56070

drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c

+1 −1
Original line number Diff line number Diff line
@@ -2220,7 +2220,7 @@ void qlcnic_83xx_process_rcv_ring_diag(struct qlcnic_host_sds_ring *sds_ring) 
	if (!opcode)

		return;



	ring = QLCNIC_FETCH_RING_ID(qlcnic_83xx_hndl(sts_data[0]));

	ring = QLCNIC_FETCH_RING_ID(sts_data[0]);

	qlcnic_83xx_process_rcv_diag(adapter, ring, sts_data);

	desc = &sds_ring->desc_head[consumer];

	desc->status_desc_data[0] = cpu_to_le64(STATUS_OWNER_PHANTOM);