Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5af96b9c authored by Marek Lindner's avatar Marek Lindner Committed by Simon Wunderlich
Browse files

batman-adv: fix backbone_gw refcount on queue_work() failure 



The backbone_gw refcounter is to be decreased by the queued work and
currently is never decreased if the queue_work() call fails.
Fix by checking the queue_work() return value and decrease refcount
if necessary.

Signed-off-by: default avatarMarek Lindner <mareklindner@neomailbox.ch>
Signed-off-by: default avatarSven Eckelmann <sven@narfation.org>
Signed-off-by: default avatarSimon Wunderlich <sw@simonwunderlich.de>
parent ae3cdc97

net/batman-adv/bridge_loop_avoidance.c

+8 −2
Original line number Diff line number Diff line
@@ -1772,6 +1772,7 @@ batadv_bla_loopdetect_check(struct batadv_priv *bat_priv, struct sk_buff *skb, 
{

	struct batadv_bla_backbone_gw *backbone_gw;

	struct ethhdr *ethhdr;

	bool ret;



	ethhdr = eth_hdr(skb);
@@ -1795,8 +1796,13 @@ batadv_bla_loopdetect_check(struct batadv_priv *bat_priv, struct sk_buff *skb, 
	if (unlikely(!backbone_gw))

		return true;



	queue_work(batadv_event_workqueue, &backbone_gw->report_work);

	/* backbone_gw is unreferenced in the report work function function */

	ret = queue_work(batadv_event_workqueue, &backbone_gw->report_work);



	/* backbone_gw is unreferenced in the report work function function

	 * if queue_work() call was successful

	 */

	if (!ret)

		batadv_backbone_gw_put(backbone_gw);



	return true;

}