Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5ae1493c authored by David Sterba's avatar David Sterba Committed by Greg Kroah-Hartman
Browse files

btrfs: delete pointless BUG_ON check on quota root in btrfs_qgroup_account_extent() 



[ Upstream commit f40a3ea94881f668084f68f6b9931486b1606db0 ]

The BUG_ON is deep in the qgroup code where we can expect that it
exists. A NULL pointer would cause a crash.

It was added long ago in 550d7a2e ("btrfs: qgroup: Add new qgroup
calculation function btrfs_qgroup_account_extents()."). It maybe made
sense back then as the quota enable/disable state machine was not that
robust as it is nowadays, so we can just delete it.

Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent f0b54836

fs/btrfs/qgroup.c

+0 −2
Original line number Diff line number Diff line
@@ -2095,8 +2095,6 @@ int btrfs_qgroup_account_extent(struct btrfs_trans_handle *trans, u64 bytenr, 
	if (nr_old_roots == 0 && nr_new_roots == 0)

		goto out_free;



	BUG_ON(!fs_info->quota_root);



	trace_btrfs_qgroup_account_extent(fs_info, trans->transid, bytenr,

					num_bytes, nr_old_roots, nr_new_roots);