Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5a8a1ab7 authored by Ivan Vecera's avatar Ivan Vecera Committed by David S. Miller
Browse files

be2net: do external loopback test only when it is requested 



v2: remove unnecessary braces from all 'loopback' if-blocks (thx Sergei)

Cc: sathya.perla@emulex.com
Cc: subbu.seetharaman@emulex.com
Cc: ajit.khaparde@emulex.com
Cc: sergei.shtylyov@cogentembedded.com

Signed-off-by: default avatarIvan Vecera <ivecera@redhat.com>
Acked-by: default avatarAjit Khaparde <ajit.khaparde@emulex.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent d0ceebd7

drivers/net/ethernet/emulex/benet/be_ethtool.c

+9 −7
Original line number Diff line number Diff line
@@ -802,16 +802,18 @@ be_self_test(struct net_device *netdev, struct ethtool_test *test, u64 *data) 


	if (test->flags & ETH_TEST_FL_OFFLINE) {

		if (be_loopback_test(adapter, BE_MAC_LOOPBACK,

						&data[0]) != 0) {

				     &data[0]) != 0)

			test->flags |= ETH_TEST_FL_FAILED;

		}



		if (be_loopback_test(adapter, BE_PHY_LOOPBACK,

						&data[1]) != 0) {

				     &data[1]) != 0)

			test->flags |= ETH_TEST_FL_FAILED;

		}



		if (test->flags & ETH_TEST_FL_EXTERNAL_LB) {

			if (be_loopback_test(adapter, BE_ONE_PORT_EXT_LOOPBACK,

						&data[2]) != 0) {

					     &data[2]) != 0)

				test->flags |= ETH_TEST_FL_FAILED;

			test->flags |= ETH_TEST_FL_EXTERNAL_LB_DONE;

		}

	}