Commit 5a6f294e authored Jun 03, 2013 by Takashi Iwai

ALSA: hda/via - Fix wrongly cleared pins after suspend on VT1802



VIA driver has a special suspend handling only for VT1802 to reduce
the pop noise.  During the transition to the generic parser, the
behavior of snd_hda_set_pin_ctl() was also changed to modify the
cached values, too.  And this caused a regression where the pin is
still cleared even after the resume (including the resume from power
save), resulting in the silent output.

The fix is simply to replace snd_hda_set_pin_ctl() with the explicit
call of snd_hda_codec_write() again.

Reported-by: Alex Riesen <raa.lkml@gmail.com>
Cc: <stable@vger.kernel.org> [v3.9]
Signed-off-by: Takashi Iwai <tiwai@suse.de>

parent 05909d5c

sound/pci/hda/patch_via.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -484,7 +484,9 @@ static int via_suspend(struct hda_codec *codec)
		/* Fix pop noise on headphones */
		int i;
		for (i = 0; i < spec->gen.autocfg.hp_outs; i++)
		snd_hda_set_pin_ctl(codec, spec->gen.autocfg.hp_pins[i], 0);
		snd_hda_codec_write(codec, spec->gen.autocfg.hp_pins[i],
		0, AC_VERB_SET_PIN_WIDGET_CONTROL,
		0x00);
		}

		return 0;