Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5a58bc1b authored by Sai Praneeth's avatar Sai Praneeth Committed by Ingo Molnar
Browse files

efi/x86: Use non-blocking SetVariable() for efi_delete_dummy_variable() 



Presently, efi_delete_dummy_variable() uses set_variable() which might
block, which the scheduler is rightfully upset about when used from
the idle thread, producing this splat:

  "bad: scheduling from the idle thread!"

So, make efi_delete_dummy_variable() use set_variable_nonblocking(),
which, as the name suggests, doesn't block.

Signed-off-by: default avatarSai Praneeth Prakhya <sai.praneeth.prakhya@intel.com>
Signed-off-by: default avatarArd Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-efi@vger.kernel.org
Link: http://lkml.kernel.org/r/20180711094040.12506-3-ard.biesheuvel@linaro.org


Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
parent 90a2186b

arch/x86/platform/efi/quirks.c

+5 −6
Original line number Diff line number Diff line
@@ -105,12 +105,11 @@ early_param("efi_no_storage_paranoia", setup_storage_paranoia); 
*/

void efi_delete_dummy_variable(void)

{

	efi.set_variable((efi_char16_t *)efi_dummy_name,

	efi.set_variable_nonblocking((efi_char16_t *)efi_dummy_name,

				     &EFI_DUMMY_GUID,

				     EFI_VARIABLE_NON_VOLATILE |

				     EFI_VARIABLE_BOOTSERVICE_ACCESS |

			 EFI_VARIABLE_RUNTIME_ACCESS,

			 0, NULL);

				     EFI_VARIABLE_RUNTIME_ACCESS, 0, NULL);

}



/*