Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5a30e0b6 authored by Malcolm Priestley's avatar Malcolm Priestley Committed by Greg Kroah-Hartman
Browse files

staging: vt6656: Clean up RXvFreeRCB. 



Clean up white space, comments and camel case.

Camel case changes
pRCB -> rcb
bReAllocSkb -> re_alloc_skb
pDevice -> priv

Signed-off-by: default avatarMalcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 49d73a98

drivers/staging/vt6656/dpc.c

+27 −26
Original line number Diff line number Diff line
@@ -1323,39 +1323,40 @@ void RXvWorkItem(struct work_struct *work) 
	spin_unlock_irq(&priv->lock);

}



void RXvFreeRCB(struct vnt_rcb *pRCB, int bReAllocSkb)

void RXvFreeRCB(struct vnt_rcb *rcb, int re_alloc_skb)

{

	struct vnt_private *pDevice = pRCB->pDevice;

	struct vnt_private *priv = rcb->pDevice;



	DBG_PRT(MSG_LEVEL_DEBUG, KERN_INFO"---->RXvFreeRCB\n");



	if (bReAllocSkb == false) {

		kfree_skb(pRCB->skb);

		bReAllocSkb = true;

	if (re_alloc_skb == false) {

		kfree_skb(rcb->skb);

		re_alloc_skb = true;

	}



    if (bReAllocSkb == true) {

        pRCB->skb = dev_alloc_skb((int)pDevice->rx_buf_sz);

        // todo error handling

        if (pRCB->skb == NULL) {

            DBG_PRT(MSG_LEVEL_ERR,KERN_ERR" Failed to re-alloc rx skb\n");

	if (re_alloc_skb == true) {

		rcb->skb = dev_alloc_skb((int)priv->rx_buf_sz);

		/* TODO error handling */

		if (rcb->skb == NULL) {

			DBG_PRT(MSG_LEVEL_ERR, KERN_ERR

				" Failed to re-alloc rx skb\n");

		} else {

            pRCB->skb->dev = pDevice->dev;

			rcb->skb->dev = priv->dev;

		}

	}

    //

    // Insert the RCB back in the Recv free list

    //

    EnqueueRCB(pDevice->FirstRecvFreeList, pDevice->LastRecvFreeList, pRCB);

    pDevice->NumRecvFreeList++;



    if ((pDevice->Flags & fMP_POST_READS) && MP_IS_READY(pDevice) &&

        (pDevice->bIsRxWorkItemQueued == false) ) {

	/* Insert the RCB back in the Recv free list */

	EnqueueRCB(priv->FirstRecvFreeList, priv->LastRecvFreeList, rcb);

	priv->NumRecvFreeList++;



        pDevice->bIsRxWorkItemQueued = true;

	schedule_work(&pDevice->read_work_item);

	if ((priv->Flags & fMP_POST_READS) && MP_IS_READY(priv) &&

			(priv->bIsRxWorkItemQueued == false)) {

		priv->bIsRxWorkItemQueued = true;

		schedule_work(&priv->read_work_item);

	}

    DBG_PRT(MSG_LEVEL_DEBUG, KERN_INFO"<----RXFreeRCB %d %d\n",pDevice->NumRecvFreeList, pDevice->NumRecvMngList);



	DBG_PRT(MSG_LEVEL_DEBUG, KERN_INFO"<----RXFreeRCB %d %d\n",

			priv->NumRecvFreeList, priv->NumRecvMngList);

}



void RXvMngWorkItem(struct work_struct *work)