Commit 5a072ef6 authored Jun 24, 2019 by Stefano Brivio Committed by Greg Kroah-Hartman Aug 29, 2019

netfilter: ipset: Actually allow destination MAC address for hash:ip,mac sets too



[ Upstream commit b89d15480d0cacacae1a0fe0b3da01b529f2914f ]

In commit 8cc4ccf58379 ("ipset: Allow matching on destination MAC address
for mac and ipmac sets"), ipset.git commit 1543514c46a7, I removed the
KADT check that prevents matching on destination MAC addresses for
hash:mac sets, but forgot to remove the same check for hash:ip,mac set.

Drop this check: functionality is now commented in man pages and there's
no reason to restrict to source MAC address matching anymore.

Reported-by: Chen Yi <yiche@redhat.com>
Fixes: 8cc4ccf58379 ("ipset: Allow matching on destination MAC address for mac and ipmac sets")
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Signed-off-by: Jozsef Kadlecsik <kadlec@netfilter.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent ba42212a

net/netfilter/ipset/ip_set_hash_ipmac.c

+0 −4

Original line number	Diff line number	Diff line
		@@ -95,10 +95,6 @@ hash_ipmac4_kadt(struct ip_set set, const struct sk_buff skb,
		struct hash_ipmac4_elem e = { .ip = 0, { .foo[0] = 0, .foo[1] = 0 } };
		struct ip_set_ext ext = IP_SET_INIT_KEXT(skb, opt, set);

		/* MAC can be src only */
		if (!(opt->flags & IPSET_DIM_TWO_SRC))
		return 0;

		if (skb_mac_header(skb) < skb->head \|\|
		(skb_mac_header(skb) + ETH_HLEN) > skb->data)
		return -EINVAL;