Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 597c606f authored by Jiri Slaby's avatar Jiri Slaby Committed by Greg Kroah-Hartman
Browse files

parisc: cleanup console handling 



* use newly added for_each_console for iterating consoles
* add proper console locking
* do not initialize tmp twice
* no need to declare console_drivers, it's already done in console.h

Signed-off-by: default avatarJiri Slaby <jslaby@suse.cz>
Acked-by: default avatarKyle McMartin <kyle@mcmartin.ca>
Cc: Helge Deller <deller@gmx.de>
Cc: "James E.J. Bottomley" <jejb@parisc-linux.org>
Cc: linux-parisc@vger.kernel.org
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 23308ba5

arch/parisc/kernel/pdc_cons.c

+4 −4
Original line number Diff line number Diff line
@@ -92,8 +92,6 @@ static int pdc_console_setup(struct console *co, char *options) 


static struct timer_list pdc_console_timer;



extern struct console * console_drivers;



static int pdc_console_tty_open(struct tty_struct *tty, struct file *filp)

{
@@ -169,11 +167,13 @@ static int __init pdc_console_tty_driver_init(void) 
	 * It is unregistered if the pdc console was not selected as the

	 * primary console. */



	struct console *tmp = console_drivers;

	struct console *tmp;



	for (tmp = console_drivers; tmp; tmp = tmp->next)

	acquire_console_sem();

	for_each_console(tmp)

		if (tmp == &pdc_cons)

			break;

	release_console_sem();



	if (!tmp) {

		printk(KERN_INFO "PDC console driver not registered anymore, not creating %s\n", pdc_cons.name);