Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 588005e1 authored by Hans-Jürgen Koch's avatar Hans-Jürgen Koch Committed by Mauro Carvalho Chehab
Browse files

V4L/DVB (6215): Bugfix for saa6588.c, add forgotten spin_lock_init() 



There's a serious bug in saa6588.c, it uses a non-initialized spin_lock.
Funny thing is that it works fine with bttv, but completly freezes the
machine if e.g. saa7134 is loaded.

Thanks to Derek Philip for reporting this bug on the rdsd-devel list.

This patch adds the missing spin_lock_init().

Signed-off-by: default avatarHans J. Koch <hjk@linutronix.de>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@infradead.org>
parent 39f46ade

drivers/media/video/saa6588.c

+1 −0
Original line number Diff line number Diff line
@@ -406,6 +406,7 @@ static int saa6588_attach(struct i2c_adapter *adap, int addr, int kind) 
		kfree(s);

		return -ENOMEM;

	}

	spin_lock_init(&s->lock);

	s->client = client_template;

	s->block_count = 0;

	s->wr_index = 0;