Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 57d3c7b0 authored by Marc Kleine-Budde's avatar Marc Kleine-Budde
Browse files

can: mcp251x: fix NOHZ local_softirq_pending 08 warning 



This patch replaces netif_rx() with netif_rx_ni() which has to be used
from the threaded interrupt i.e. process context context.

Thanks to Christian Pellegrin for pointing at the right fix:
481a8199 by Oliver Hartkopp.

Signed-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
Acked-by: default avatarWolfgang Grandegger <wg@grandegger.com>
parent 724829b3

drivers/net/can/mcp251x.c

+2 −2
Original line number Diff line number Diff line
@@ -451,7 +451,7 @@ static void mcp251x_hw_rx(struct spi_device *spi, int buf_idx) 


	priv->net->stats.rx_packets++;

	priv->net->stats.rx_bytes += frame->can_dlc;

	netif_rx(skb);

	netif_rx_ni(skb);

}



static void mcp251x_hw_sleep(struct spi_device *spi)
@@ -676,7 +676,7 @@ static void mcp251x_error_skb(struct net_device *net, int can_id, int data1) 
	if (skb) {

		frame->can_id = can_id;

		frame->data[1] = data1;

		netif_rx(skb);

		netif_rx_ni(skb);

	} else {

		dev_err(&net->dev,

			"cannot allocate error skb\n");