Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 57c10b61 authored by Peter Senna Tschudin's avatar Peter Senna Tschudin Committed by David S. Miller
Browse files

drivers/net/ethernet/nxp/lpc_eth.c: Call mdiobus_unregister before mdiobus_free 

Based on commit b27393ae

Calling mdiobus_free without calling mdiobus_unregister causes
BUG_ON(). This patch fixes the issue.

The semantic patch that found this issue(http://coccinelle.lip6.fr/

):
// <smpl>
@@
expression E;
@@
  ... when != mdiobus_unregister(E);

+ mdiobus_unregister(E);
  mdiobus_free(E);
// </smpl>

Signed-off-by: default avatarPeter Senna Tschudin <peter.senna@gmail.com>
Tested-by: default avatarRoland Stigge <stigge@antcom.de>
Tested-by: default avatarAlexandre Pereira da Silva <aletes.xgr@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 2b674047

drivers/net/ethernet/nxp/lpc_eth.c

+1 −0
Original line number Diff line number Diff line
@@ -1524,6 +1524,7 @@ static int lpc_eth_drv_remove(struct platform_device *pdev) 
				  pldat->dma_buff_base_p);

	free_irq(ndev->irq, ndev);

	iounmap(pldat->net_base);

	mdiobus_unregister(pldat->mii_bus);

	mdiobus_free(pldat->mii_bus);

	clk_disable(pldat->clk);

	clk_put(pldat->clk);