Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5785e87a authored by Yoshihiro Shimoda's avatar Yoshihiro Shimoda Committed by Felipe Balbi
Browse files

usb: renesas_usbhs: use PIPEnCLR.ACLRM instead of {C,Dn}FIFOCTR.BCLR in usbhs_pkt_pop() 



This patch uses usbhs_pipe_clear_without_sequence() instead of
usbhsf_fifo_clear() because usbhsf_fifo_clear() may not clear the pipe
buffer completely. This patch also changes the clearing condition from
DMA only to both DMA and PIO.

Signed-off-by: default avatarYoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Signed-off-by: default avatarFelipe Balbi <felipe.balbi@linux.intel.com>
parent 8d8a0435

drivers/usb/renesas_usbhs/fifo.c

+2 −3
Original line number Diff line number Diff line
@@ -94,8 +94,6 @@ static struct usbhs_pkt *__usbhsf_pkt_get(struct usbhs_pipe *pipe) 
	return list_first_entry_or_null(&pipe->list, struct usbhs_pkt, node);

}



static void usbhsf_fifo_clear(struct usbhs_pipe *pipe,

			      struct usbhs_fifo *fifo);

static void usbhsf_fifo_unselect(struct usbhs_pipe *pipe,

				 struct usbhs_fifo *fifo);

static struct dma_chan *usbhsf_dma_chan_get(struct usbhs_fifo *fifo,
@@ -124,10 +122,11 @@ struct usbhs_pkt *usbhs_pkt_pop(struct usbhs_pipe *pipe, struct usbhs_pkt *pkt) 
			chan = usbhsf_dma_chan_get(fifo, pkt);

		if (chan) {

			dmaengine_terminate_all(chan);

			usbhsf_fifo_clear(pipe, fifo);

			usbhsf_dma_unmap(pkt);

		}



		usbhs_pipe_clear_without_sequence(pipe, 0, 0);



		__usbhsf_pkt_del(pkt);

	}