Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 576333a1 authored by Frode Isaksen's avatar Frode Isaksen Committed by Mark Brown
Browse files

spi: loopback-test: add option to use vmalloc'ed buffers 



Using vmalloc'ed buffers will use one SG entry for each page,
that may provoke DMA errors for large transfers.
Also vmalloc'ed buffers may cause errors on CPU's with VIVT cache.
Add this option to catch these errors when testing.
Note that to catch VIVT cache errors, checking the rx range
has to be disabled, so this option has been added as well.

Signed-off-by: default avatarFrode Isaksen <fisaksen@baylibre.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent fafd6794

drivers/spi/spi-loopback-test.c

+27 −7
Original line number Original line Diff line number Diff line
@@ -55,6 +55,18 @@ module_param(run_only_test, int, 0); 
MODULE_PARM_DESC(run_only_test,

MODULE_PARM_DESC(run_only_test,

		 "only run the test with this number (0-based !)");

		 "only run the test with this number (0-based !)");





/* use vmalloc'ed buffers */

int use_vmalloc;

module_param(use_vmalloc, int, 0644);

MODULE_PARM_DESC(use_vmalloc,

		 "use vmalloc'ed buffers instead of kmalloc'ed");



/* check rx ranges */

int check_ranges = 1;

module_param(check_ranges, int, 0644);

MODULE_PARM_DESC(check_ranges,

		 "checks rx_buffer pattern are valid");



/* the actual tests to execute */

/* the actual tests to execute */

static struct spi_test spi_tests[] = {

static struct spi_test spi_tests[] = {

	{

	{
@@ -492,9 +504,11 @@ static int spi_test_check_loopback_result(struct spi_device *spi, 
	int ret;

	int ret;





	/* checks rx_buffer pattern are valid with loopback or without */

	/* checks rx_buffer pattern are valid with loopback or without */

	if (check_ranges) {

		ret = spi_check_rx_ranges(spi, msg, rx);

		ret = spi_check_rx_ranges(spi, msg, rx);

		if (ret)

		if (ret)

			return ret;

			return ret;

	}





	/* if we run without loopback, then return now */

	/* if we run without loopback, then return now */

	if (!loopback)

	if (!loopback)
@@ -965,12 +979,18 @@ int spi_test_run_tests(struct spi_device *spi, 
	/* allocate rx/tx buffers of 128kB size without devm

	/* allocate rx/tx buffers of 128kB size without devm

	 * in the hope that is on a page boundary

	 * in the hope that is on a page boundary

	 */

	 */

	if (use_vmalloc)

		rx = vmalloc(SPI_TEST_MAX_SIZE_PLUS);

	else

		rx = kzalloc(SPI_TEST_MAX_SIZE_PLUS, GFP_KERNEL);

		rx = kzalloc(SPI_TEST_MAX_SIZE_PLUS, GFP_KERNEL);

	if (!rx) {

	if (!rx) {

		ret = -ENOMEM;

		ret = -ENOMEM;

		goto out;

		goto out;

	}

	}





	if (use_vmalloc)

		tx = vmalloc(SPI_TEST_MAX_SIZE_PLUS);

	else

		tx = kzalloc(SPI_TEST_MAX_SIZE_PLUS, GFP_KERNEL);

		tx = kzalloc(SPI_TEST_MAX_SIZE_PLUS, GFP_KERNEL);

	if (!tx) {

	if (!tx) {

		ret = -ENOMEM;

		ret = -ENOMEM;
@@ -999,8 +1019,8 @@ int spi_test_run_tests(struct spi_device *spi, 
	}

	}





out:

out:

	kfree(rx);

	kvfree(rx);

	kfree(tx);

	kvfree(tx);

	return ret;

	return ret;

}

}

EXPORT_SYMBOL_GPL(spi_test_run_tests);
 
EXPORT_SYMBOL_GPL(spi_test_run_tests);