Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 573ce1c1 authored by Steffen Klassert's avatar Steffen Klassert
Browse files

xfrm6: Remove xfrm_tunnel_notifier 



This was used from vti and is replaced by the IPsec protocol
multiplexer hooks. It is now unused, so remove it.

Signed-off-by: default avatarSteffen Klassert <steffen.klassert@secunet.com>
parent fa9ad96d

include/net/xfrm.h

+0 −8
Original line number Diff line number Diff line
@@ -1393,12 +1393,6 @@ struct xfrm_tunnel { 
	int priority;

};



struct xfrm_tunnel_notifier {

	int (*handler)(struct sk_buff *skb);

	struct xfrm_tunnel_notifier __rcu *next;

	int priority;

};



struct xfrm6_tunnel {

	int (*handler)(struct sk_buff *skb);

	int (*err_handler)(struct sk_buff *skb, struct inet6_skb_parm *opt,
@@ -1554,8 +1548,6 @@ int xfrm4_protocol_deregister(struct xfrm4_protocol *handler, unsigned char prot 
int xfrm4_tunnel_register(struct xfrm_tunnel *handler, unsigned short family);

int xfrm4_tunnel_deregister(struct xfrm_tunnel *handler, unsigned short family);

void xfrm4_local_error(struct sk_buff *skb, u32 mtu);

int xfrm6_mode_tunnel_input_register(struct xfrm_tunnel_notifier *handler);

int xfrm6_mode_tunnel_input_deregister(struct xfrm_tunnel_notifier *handler);

int xfrm6_extract_header(struct sk_buff *skb);

int xfrm6_extract_input(struct xfrm_state *x, struct sk_buff *skb);

int xfrm6_rcv_spi(struct sk_buff *skb, int nexthdr, __be32 spi);

net/ipv6/xfrm6_mode_tunnel.c

+0 −63
Original line number Diff line number Diff line
@@ -18,65 +18,6 @@ 
#include <net/ipv6.h>

#include <net/xfrm.h>



/* Informational hook. The decap is still done here. */

static struct xfrm_tunnel_notifier __rcu *rcv_notify_handlers __read_mostly;

static DEFINE_MUTEX(xfrm6_mode_tunnel_input_mutex);



int xfrm6_mode_tunnel_input_register(struct xfrm_tunnel_notifier *handler)

{

	struct xfrm_tunnel_notifier __rcu **pprev;

	struct xfrm_tunnel_notifier *t;

	int ret = -EEXIST;

	int priority = handler->priority;



	mutex_lock(&xfrm6_mode_tunnel_input_mutex);



	for (pprev = &rcv_notify_handlers;

	     (t = rcu_dereference_protected(*pprev,

	     lockdep_is_held(&xfrm6_mode_tunnel_input_mutex))) != NULL;

	     pprev = &t->next) {

		if (t->priority > priority)

			break;

		if (t->priority == priority)

			goto err;



	}



	handler->next = *pprev;

	rcu_assign_pointer(*pprev, handler);



	ret = 0;



err:

	mutex_unlock(&xfrm6_mode_tunnel_input_mutex);

	return ret;

}

EXPORT_SYMBOL_GPL(xfrm6_mode_tunnel_input_register);



int xfrm6_mode_tunnel_input_deregister(struct xfrm_tunnel_notifier *handler)

{

	struct xfrm_tunnel_notifier __rcu **pprev;

	struct xfrm_tunnel_notifier *t;

	int ret = -ENOENT;



	mutex_lock(&xfrm6_mode_tunnel_input_mutex);

	for (pprev = &rcv_notify_handlers;

	     (t = rcu_dereference_protected(*pprev,

	     lockdep_is_held(&xfrm6_mode_tunnel_input_mutex))) != NULL;

	     pprev = &t->next) {

		if (t == handler) {

			*pprev = handler->next;

			ret = 0;

			break;

		}

	}

	mutex_unlock(&xfrm6_mode_tunnel_input_mutex);

	synchronize_net();



	return ret;

}

EXPORT_SYMBOL_GPL(xfrm6_mode_tunnel_input_deregister);



static inline void ipip6_ecn_decapsulate(struct sk_buff *skb)

{

	const struct ipv6hdr *outer_iph = ipv6_hdr(skb);
@@ -130,7 +71,6 @@ static int xfrm6_mode_tunnel_output(struct xfrm_state *x, struct sk_buff *skb) 


static int xfrm6_mode_tunnel_input(struct xfrm_state *x, struct sk_buff *skb)

{

	struct xfrm_tunnel_notifier *handler;

	int err = -EINVAL;



	if (XFRM_MODE_SKB_CB(skb)->protocol != IPPROTO_IPV6)
@@ -138,9 +78,6 @@ static int xfrm6_mode_tunnel_input(struct xfrm_state *x, struct sk_buff *skb) 
	if (!pskb_may_pull(skb, sizeof(struct ipv6hdr)))

		goto out;



	for_each_input_rcu(rcv_notify_handlers, handler)

		handler->handler(skb);



	err = skb_unclone(skb, GFP_ATOMIC);

	if (err)

		goto out;