Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 572d8fda authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Dave Airlie
Browse files

char: amd64-agp: Use 64-bit arithmetic instead of 32-bit 



Cast *tmp* and *nb_base* to u64 in order to give the compiler
complete information about the proper arithmetic to use.

Notice that such variables are used in contexts that expect
expressions of type u64 (64 bits, unsigned) and the following
expressions are currently being evaluated using 32-bit arithmetic:

tmp << 25
nb_base << 25

Addresses-Coverity-ID: 200586 ("Unintentional integer overflow")
Addresses-Coverity-ID: 200587 ("Unintentional integer overflow")
Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
parent 8fb8876b

drivers/char/agp/amd64-agp.c

+2 −2
Original line number Diff line number Diff line
@@ -156,7 +156,7 @@ static u64 amd64_configure(struct pci_dev *hammer, u64 gatt_table) 


	/* Address to map to */

	pci_read_config_dword(hammer, AMD64_GARTAPERTUREBASE, &tmp);

	aperturebase = tmp << 25;

	aperturebase = (u64)tmp << 25;

	aper_base = (aperturebase & PCI_BASE_ADDRESS_MEM_MASK);



	enable_gart_translation(hammer, gatt_table);
@@ -277,7 +277,7 @@ static int fix_northbridge(struct pci_dev *nb, struct pci_dev *agp, u16 cap) 
	pci_read_config_dword(nb, AMD64_GARTAPERTURECTL, &nb_order);

	nb_order = (nb_order >> 1) & 7;

	pci_read_config_dword(nb, AMD64_GARTAPERTUREBASE, &nb_base);

	nb_aper = nb_base << 25;

	nb_aper = (u64)nb_base << 25;



	/* Northbridge seems to contain crap. Try the AGP bridge. */