Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5728d95f authored by Sifan Naeem's avatar Sifan Naeem Committed by Wolfram Sang
Browse files

i2c: img-scb: use DIV_ROUND_UP to round divisor values 



Using % can be slow depending on the architecture.

Using DIV_ROUND_UP is nicer and more efficient way to do it.

Fixes: commit 27bce457 ("i2c: img-scb: Add Imagination Technologies I2C SCB driver")
Signed-off-by: default avatarSifan Naeem <sifan.naeem@imgtec.com>
Acked-by: default avatarJames Hogan <james.hogan@imgtec.com>
Reviewed-by: default avatarJames Hartley <james.hartley@imgtec.com>
Signed-off-by: default avatarWolfram Sang <wsa@the-dreams.de>
parent 2aefb1bd

drivers/i2c/busses/i2c-img-scb.c

+2 −6
Original line number Diff line number Diff line
@@ -1179,9 +1179,7 @@ static int img_i2c_init(struct img_i2c *i2c) 
		int_bitrate++;



	/* Setup TCKH value */

	tckh = timing.tckh / clk_period;

	if (timing.tckh % clk_period)

		tckh++;

	tckh = DIV_ROUND_UP(timing.tckh, clk_period);



	if (tckh > 0)

		data = tckh - 1;
@@ -1201,9 +1199,7 @@ static int img_i2c_init(struct img_i2c *i2c) 
	img_i2c_writel(i2c, SCB_TIME_TCKL_REG, data);



	/* Setup TSDH value */

	tsdh = timing.tsdh / clk_period;

	if (timing.tsdh % clk_period)

		tsdh++;

	tsdh = DIV_ROUND_UP(timing.tsdh, clk_period);



	if (tsdh > 1)

		data = tsdh - 1;