Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 56cbbf25 authored by Noralf Trønnes's avatar Noralf Trønnes Committed by Daniel Vetter
Browse files

drm/tilcdc: Remove tilcdc_debugfs_cleanup() 



drm_debugfs_cleanup() now removes all minor->debugfs_list entries
automatically, so the drm_driver.debugfs_cleanup callback is not
needed. Also remove the unused tilcdc_module_ops.debugfs_cleanup()
callback. drm_debugfs_cleanup() removes all debugfs files using
debugfs_remove_recursive(), so there should be no need for such a
callback in the future.

Cc: jsarha@ti.com
Cc: tomi.valkeinen@ti.com
Signed-off-by: default avatarNoralf Trønnes <noralf@tronnes.org>
Reviewed-by: default avatarJyri Sarha <jsarha@ti.com>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/20170126225621.12314-16-noralf@tronnes.org
parent 5b6954b9

drivers/gpu/drm/tilcdc/tilcdc_drv.c

+0 −12
Original line number Diff line number Diff line
@@ -539,17 +539,6 @@ static int tilcdc_debugfs_init(struct drm_minor *minor) 


	return ret;

}



static void tilcdc_debugfs_cleanup(struct drm_minor *minor)

{

	struct tilcdc_module *mod;

	drm_debugfs_remove_files(tilcdc_debugfs_list,

			ARRAY_SIZE(tilcdc_debugfs_list), minor);



	list_for_each_entry(mod, &module_list, list)

		if (mod->funcs->debugfs_cleanup)

			mod->funcs->debugfs_cleanup(mod, minor);

}

#endif



static const struct file_operations fops = {
@@ -589,7 +578,6 @@ static struct drm_driver tilcdc_driver = { 
	.gem_prime_mmap		= drm_gem_cma_prime_mmap,

#ifdef CONFIG_DEBUG_FS

	.debugfs_init       = tilcdc_debugfs_init,

	.debugfs_cleanup    = tilcdc_debugfs_cleanup,

#endif

	.fops               = &fops,

	.name               = "tilcdc",

drivers/gpu/drm/tilcdc/tilcdc_drv.h

+0 −2
Original line number Diff line number Diff line
@@ -111,8 +111,6 @@ struct tilcdc_module_ops { 
#ifdef CONFIG_DEBUG_FS

	/* create debugfs nodes (can be NULL): */

	int (*debugfs_init)(struct tilcdc_module *mod, struct drm_minor *minor);

	/* cleanup debugfs nodes (can be NULL): */

	void (*debugfs_cleanup)(struct tilcdc_module *mod, struct drm_minor *minor);

#endif

};