Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 56c0c529 authored by Alexandre Belloni's avatar Alexandre Belloni
Browse files

rtc: pxa: fix possible race condition 



pxa_rtc_open() registers the interrupt handler which will access the RTC
registers. However, pxa_rtc_open() is called before the register range is
ioremapped. Instead, call it after devm_ioremap().

Acked-by: default avatarRobert Jarzmik <robert.jarzmik@free.fr>
Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@free-electrons.com>
parent be8e2746

drivers/rtc/rtc-pxa.c

+3 −1
Original line number Diff line number Diff line
@@ -348,7 +348,7 @@ static int __init pxa_rtc_probe(struct platform_device *pdev) 
		dev_err(dev, "No alarm IRQ resource defined\n");

		return -ENXIO;

	}

	pxa_rtc_open(dev);



	pxa_rtc->base = devm_ioremap(dev, pxa_rtc->ress->start,

				resource_size(pxa_rtc->ress));

	if (!pxa_rtc->base) {
@@ -356,6 +356,8 @@ static int __init pxa_rtc_probe(struct platform_device *pdev) 
		return -ENOMEM;

	}



	pxa_rtc_open(dev);



	sa1100_rtc->rcnr = pxa_rtc->base + 0x0;

	sa1100_rtc->rtsr = pxa_rtc->base + 0x8;

	sa1100_rtc->rtar = pxa_rtc->base + 0x4;