Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 568991c9 authored by Colin Ian King's avatar Colin Ian King Committed by Greg Kroah-Hartman
Browse files

staging: rtl8723bs: fix copy of overlapping memory 



commit 8ae9a588ca35eb9c32dc03299c5e1f4a1e9a9617 upstream.

Currently the rtw_sprintf prints the contents of thread_name
onto thread_name and this can lead to a potential copy of a
string over itself. Avoid this by printing the literal string RTWHALXT
instread of the contents of thread_name.

Addresses-Coverity: ("copy of overlapping memory")
Fixes: 554c0a3a ("staging: Add rtl8723bs sdio wifi driver")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20200126220549.9849-1-colin.king@canonical.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent f8e6a341

drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c

+2 −3
Original line number Diff line number Diff line
@@ -478,14 +478,13 @@ int rtl8723bs_xmit_thread(void *context) 
	s32 ret;

	struct adapter *padapter;

	struct xmit_priv *pxmitpriv;

	u8 thread_name[20] = "RTWHALXT";



	u8 thread_name[20];



	ret = _SUCCESS;

	padapter = context;

	pxmitpriv = &padapter->xmitpriv;



	rtw_sprintf(thread_name, 20, "%s-"ADPT_FMT, thread_name, ADPT_ARG(padapter));

	rtw_sprintf(thread_name, 20, "RTWHALXT-" ADPT_FMT, ADPT_ARG(padapter));

	thread_enter(thread_name);



	DBG_871X("start "FUNC_ADPT_FMT"\n", FUNC_ADPT_ARG(padapter));