Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 567ab5a8 authored by Roger Quadros's avatar Roger Quadros Committed by Chanwoo Choi
Browse files

extcon: palmas: Use dev_dbg macro for the debug messages 



User is not interested in USB cable events appearing on the
console. Use dev_dbg() instead of dev_info() for these events.

Signed-off-by: default avatarRoger Quadros <rogerq@ti.com>
Signed-off-by: default avatarChanwoo Choi <cw00.choi@samsung.com>
parent 86d6cda6

drivers/extcon/extcon-palmas.c

+8 −8
Original line number Diff line number Diff line
@@ -62,7 +62,7 @@ static irqreturn_t palmas_vbus_irq_handler(int irq, void *_palmas_usb) 
		if (palmas_usb->linkstat != PALMAS_USB_STATE_VBUS) {

			palmas_usb->linkstat = PALMAS_USB_STATE_VBUS;

			extcon_set_state_sync(edev, EXTCON_USB, true);

			dev_info(palmas_usb->dev, "USB cable is attached\n");

			dev_dbg(palmas_usb->dev, "USB cable is attached\n");

		} else {

			dev_dbg(palmas_usb->dev,

				"Spurious connect event detected\n");
@@ -71,7 +71,7 @@ static irqreturn_t palmas_vbus_irq_handler(int irq, void *_palmas_usb) 
		if (palmas_usb->linkstat == PALMAS_USB_STATE_VBUS) {

			palmas_usb->linkstat = PALMAS_USB_STATE_DISCONNECT;

			extcon_set_state_sync(edev, EXTCON_USB, false);

			dev_info(palmas_usb->dev, "USB cable is detached\n");

			dev_dbg(palmas_usb->dev, "USB cable is detached\n");

		} else {

			dev_dbg(palmas_usb->dev,

				"Spurious disconnect event detected\n");
@@ -99,7 +99,7 @@ static irqreturn_t palmas_id_irq_handler(int irq, void *_palmas_usb) 
			PALMAS_USB_ID_INT_EN_HI_CLR_ID_GND);

		palmas_usb->linkstat = PALMAS_USB_STATE_ID;

		extcon_set_state_sync(edev, EXTCON_USB_HOST, true);

		dev_info(palmas_usb->dev, "USB-HOST cable is attached\n");

		dev_dbg(palmas_usb->dev, "USB-HOST cable is attached\n");

	} else if ((set & PALMAS_USB_ID_INT_SRC_ID_FLOAT) &&

				(id_src & PALMAS_USB_ID_INT_SRC_ID_FLOAT)) {

		palmas_write(palmas_usb->palmas, PALMAS_USB_OTG_BASE,
@@ -107,17 +107,17 @@ static irqreturn_t palmas_id_irq_handler(int irq, void *_palmas_usb) 
			PALMAS_USB_ID_INT_EN_HI_CLR_ID_FLOAT);

		palmas_usb->linkstat = PALMAS_USB_STATE_DISCONNECT;

		extcon_set_state_sync(edev, EXTCON_USB_HOST, false);

		dev_info(palmas_usb->dev, "USB-HOST cable is detached\n");

		dev_dbg(palmas_usb->dev, "USB-HOST cable is detached\n");

	} else if ((palmas_usb->linkstat == PALMAS_USB_STATE_ID) &&

				(!(set & PALMAS_USB_ID_INT_SRC_ID_GND))) {

		palmas_usb->linkstat = PALMAS_USB_STATE_DISCONNECT;

		extcon_set_state_sync(edev, EXTCON_USB_HOST, false);

		dev_info(palmas_usb->dev, "USB-HOST cable is detached\n");

		dev_dbg(palmas_usb->dev, "USB-HOST cable is detached\n");

	} else if ((palmas_usb->linkstat == PALMAS_USB_STATE_DISCONNECT) &&

				(id_src & PALMAS_USB_ID_INT_SRC_ID_GND)) {

		palmas_usb->linkstat = PALMAS_USB_STATE_ID;

		extcon_set_state_sync(edev, EXTCON_USB_HOST, true);

		dev_info(palmas_usb->dev, " USB-HOST cable is attached\n");

		dev_dbg(palmas_usb->dev, " USB-HOST cable is attached\n");

	}



	return IRQ_HANDLED;
@@ -138,10 +138,10 @@ static void palmas_gpio_id_detect(struct work_struct *work) 


	if (id) {

		extcon_set_state_sync(edev, EXTCON_USB_HOST, false);

		dev_info(palmas_usb->dev, "USB-HOST cable is detached\n");

		dev_dbg(palmas_usb->dev, "USB-HOST cable is detached\n");

	} else {

		extcon_set_state_sync(edev, EXTCON_USB_HOST, true);

		dev_info(palmas_usb->dev, "USB-HOST cable is attached\n");

		dev_dbg(palmas_usb->dev, "USB-HOST cable is attached\n");

	}

}