Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 564649b4 authored by Leon Romanovsky's avatar Leon Romanovsky Committed by Doug Ledford
Browse files

IB/qib: Remove empty function 



Commit f0626710 ("RDMA: Update workqueue usage") removed
content of qib_qsfp_deinit(...) and left it empty.

This patch deletes all leftovers of that function.

Signed-off-by: default avatarLeon Romanovsky <leon@kernel.org>
Reviewed-by: default avatarYuval Shaia <yuval.shaia@oracle.com>
Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
parent 21d6454a

drivers/infiniband/hw/qib/qib_iba7322.c

+0 −1
Original line number Diff line number Diff line
@@ -2893,7 +2893,6 @@ static void qib_setup_7322_cleanup(struct qib_devdata *dd) 
			dd->cspec->gpio_mask &= ~mask;

			qib_write_kreg(dd, kr_gpio_mask, dd->cspec->gpio_mask);

			spin_unlock_irqrestore(&dd->cspec->gpio_lock, flags);

			qib_qsfp_deinit(&dd->pport[i].cpspec->qsfp_data);

		}

	}

}

drivers/infiniband/hw/qib/qib_qsfp.c

+0 −10
Original line number Diff line number Diff line
@@ -485,16 +485,6 @@ void qib_qsfp_init(struct qib_qsfp_data *qd, 
	dd->f_gpio_mod(dd, mask, mask, mask);

}



void qib_qsfp_deinit(struct qib_qsfp_data *qd)

{

	/*

	 * There is nothing to do here for now.  our work is scheduled

	 * with queue_work(), and flush_workqueue() from remove_one

	 * will block until all work setup with queue_work()

	 * completes.

	 */

}



int qib_qsfp_dump(struct qib_pportdata *ppd, char *buf, int len)

{

	struct qib_qsfp_cache cd;

drivers/infiniband/hw/qib/qib_qsfp.h

+0 −1
Original line number Diff line number Diff line
@@ -186,4 +186,3 @@ extern int qib_refresh_qsfp_cache(struct qib_pportdata *ppd, 
extern int qib_qsfp_mod_present(struct qib_pportdata *ppd);

extern void qib_qsfp_init(struct qib_qsfp_data *qd,

			  void (*fevent)(struct work_struct *));
 
extern void qib_qsfp_deinit(struct qib_qsfp_data *qd);