Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 55c19eee authored by Wei Yongjun's avatar Wei Yongjun Committed by Stephen Boyd
Browse files

clk: qcom: msm8916: Fix return value check in qcom_apcs_msm8916_clk_probe() 



In case of error, the function dev_get_regmap() returns NULL pointer
not ERR_PTR(). The IS_ERR() test in the return value check should be
replaced with NULL test.

Fixes: 81ac3884 ("clk: qcom: Add APCS clock controller support")
Signed-off-by: default avatarWei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: default avatarStephen Boyd <sboyd@kernel.org>
parent 9903e41a

drivers/clk/qcom/apcs-msm8916.c

+2 −3
Original line number Original line Diff line number Diff line
@@ -49,11 +49,10 @@ static int qcom_apcs_msm8916_clk_probe(struct platform_device *pdev) 
	struct clk_regmap_mux_div *a53cc;

	struct clk_regmap_mux_div *a53cc;

	struct regmap *regmap;

	struct regmap *regmap;

	struct clk_init_data init = { };

	struct clk_init_data init = { };

	int ret;

	int ret = -ENODEV;





	regmap = dev_get_regmap(parent, NULL);

	regmap = dev_get_regmap(parent, NULL);

	if (IS_ERR(regmap)) {

	if (!regmap) {

		ret = PTR_ERR(regmap);

		dev_err(dev, "failed to get regmap: %d\n", ret);

		dev_err(dev, "failed to get regmap: %d\n", ret);

		return ret;

		return ret;

	}

	}