Commit 55b5cbaa authored Nov 06, 2019 by Steffen Klassert Committed by Greg Kroah-Hartman Dec 05, 2019

xfrm: Fix memleak on xfrm state destroy



commit 86c6739eda7d2a03f2db30cbee67a5fb81afa8ba upstream.

We leak the page that we use to create skb page fragments
when destroying the xfrm_state. Fix this by dropping a
page reference if a page was assigned to the xfrm_state.

Fixes: cac2661c ("esp4: Avoid skb_cow_data whenever possible")
Reported-by: JD <jdtxs00@gmail.com>
Reported-by: Paul Wouters <paul@nohats.ca>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent c01cffbc

net/xfrm/xfrm_state.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -456,6 +456,8 @@ static void ___xfrm_state_destroy(struct xfrm_state *x)
		x->type->destructor(x);
		xfrm_put_type(x->type);
		}
		if (x->xfrag.page)
		put_page(x->xfrag.page);
		xfrm_dev_state_free(x);
		security_xfrm_state_free(x);
		xfrm_state_free(x);