Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 556c7bb7 authored by Bjorn Helgaas's avatar Bjorn Helgaas
Browse files

PCI: iproc: Set drvdata at end of probe function 



Set the drvdata pointer at the end of probe function for consistency with
other drivers.  We don't need the drvdata until after the probe completes,
and we don't need it at all if the probe fails.  No functional change
intended.

Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
parent 786aeccb

drivers/pci/host/pcie-iproc-bcma.c

+1 −1
Original line number Diff line number Diff line
@@ -53,7 +53,6 @@ static int iproc_pcie_bcma_probe(struct bcma_device *bdev) 
		return -ENOMEM;



	pcie->dev = dev;

	bcma_set_drvdata(bdev, pcie);



	pcie->base = bdev->io_addr;

	pcie->base_addr = bdev->addr;
@@ -72,6 +71,7 @@ static int iproc_pcie_bcma_probe(struct bcma_device *bdev) 


	pci_free_resource_list(&res);



	bcma_set_drvdata(bdev, pcie);

	return ret;

}

drivers/pci/host/pcie-iproc-platform.c

+1 −1
Original line number Diff line number Diff line
@@ -59,7 +59,6 @@ static int iproc_pcie_pltfm_probe(struct platform_device *pdev) 


	pcie->dev = dev;

	pcie->type = (enum iproc_pcie_type)of_id->data;

	platform_set_drvdata(pdev, pcie);



	ret = of_address_to_resource(np, 0, &reg);

	if (ret < 0) {
@@ -124,6 +123,7 @@ static int iproc_pcie_pltfm_probe(struct platform_device *pdev) 


	pci_free_resource_list(&res);



	platform_set_drvdata(pdev, pcie);

	return ret;

}