Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 553bf6bb authored by Rik van Riel's avatar Rik van Riel Committed by Ingo Molnar
Browse files

sched/cputime: Drop local_irq_save/restore from irqtime_account_irq() 



Paolo pointed out that irqs are already blocked when irqtime_account_irq()
is called. That means there is no reason to call local_irq_save/restore()
again.

Suggested-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
Signed-off-by: default avatarRik van Riel <riel@redhat.com>
Signed-off-by: default avatarFrederic Weisbecker <fweisbec@gmail.com>
Reviewed-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Radim Krcmar <rkrcmar@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Wanpeng Li <wanpeng.li@hotmail.com>
Link: http://lkml.kernel.org/r/1468421405-20056-6-git-send-email-fweisbec@gmail.com


Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
parent 8612f17a

kernel/sched/cputime.c

+0 −4
Original line number Diff line number Diff line
@@ -49,15 +49,12 @@ DEFINE_PER_CPU(seqcount_t, irq_time_seq); 
 */

void irqtime_account_irq(struct task_struct *curr)

{

	unsigned long flags;

	s64 delta;

	int cpu;



	if (!sched_clock_irqtime)

		return;



	local_irq_save(flags);



	cpu = smp_processor_id();

	delta = sched_clock_cpu(cpu) - __this_cpu_read(irq_start_time);

	__this_cpu_add(irq_start_time, delta);
@@ -75,7 +72,6 @@ void irqtime_account_irq(struct task_struct *curr) 
		__this_cpu_add(cpu_softirq_time, delta);



	irq_time_write_end();

	local_irq_restore(flags);

}

EXPORT_SYMBOL_GPL(irqtime_account_irq);