Commit 552ee302 authored Oct 13, 2017 by Wei Yongjun Committed by Tony Lindgren Oct 13, 2017

ARM: OMAP2+: omap_device: fix error return code in omap_device_copy_resources()



Fix to return error code -EINVAL from the irq_of_parse_and_map() error
handling case instead of 0, as done elsewhere in this function.

Fixes: d85a2d61 ("ARM: OMAP2+: Populate legacy resources for dma
and smartreflex")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>

parent 9cffb1a0

arch/arm/mach-omap2/omap_device.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -433,8 +433,10 @@ omap_device_copy_resources(struct omap_hwmod *oh,
		irq = irq_of_parse_and_map(child, 0);
		if (!irq)
		irq = irq_of_parse_and_map(np, 0);
		if (!irq)
		if (!irq) {
		error = -EINVAL;
		goto free;
		}

		/* Legacy DMA code needs interrupt name to be "0" */
		res[1].start = irq;