Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5514174f authored by yuval.shaia@oracle.com's avatar yuval.shaia@oracle.com Committed by David S. Miller
Browse files

net: phy: Make phy_ethtool_ksettings_get return void



Make return value void since function never return meaningfull value

Signed-off-by: default avatarYuval Shaia <yuval.shaia@oracle.com>
Acked-by: default avatarSergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent d980b8d1
Loading
Loading
Loading
Loading
+3 −1
Original line number Diff line number Diff line
@@ -157,7 +157,9 @@ static int xge_get_link_ksettings(struct net_device *ndev,
	if (!phydev)
		return -ENODEV;

	return phy_ethtool_ksettings_get(phydev, cmd);
	phy_ethtool_ksettings_get(phydev, cmd);

	return 0;
}

static int xge_set_link_ksettings(struct net_device *ndev,
+6 −2
Original line number Diff line number Diff line
@@ -131,13 +131,17 @@ static int xgene_get_link_ksettings(struct net_device *ndev,
		if (phydev == NULL)
			return -ENODEV;

		return phy_ethtool_ksettings_get(phydev, cmd);
		phy_ethtool_ksettings_get(phydev, cmd);

		return 0;
	} else if (pdata->phy_mode == PHY_INTERFACE_MODE_SGMII) {
		if (pdata->mdio_driver) {
			if (!phydev)
				return -ENODEV;

			return phy_ethtool_ksettings_get(phydev, cmd);
			phy_ethtool_ksettings_get(phydev, cmd);

			return 0;
		}

		supported = SUPPORTED_1000baseT_Full | SUPPORTED_Autoneg |
+3 −1
Original line number Diff line number Diff line
@@ -1836,7 +1836,9 @@ static int b44_get_link_ksettings(struct net_device *dev,

	if (bp->flags & B44_FLAG_EXTERNAL_PHY) {
		BUG_ON(!dev->phydev);
		return phy_ethtool_ksettings_get(dev->phydev, cmd);
		phy_ethtool_ksettings_get(dev->phydev, cmd);

		return 0;
	}

	supported = (SUPPORTED_Autoneg);
+4 −1
Original line number Diff line number Diff line
@@ -1453,7 +1453,10 @@ static int bcm_enet_get_link_ksettings(struct net_device *dev,
	if (priv->has_phy) {
		if (!dev->phydev)
			return -ENODEV;
		return phy_ethtool_ksettings_get(dev->phydev, cmd);

		phy_ethtool_ksettings_get(dev->phydev, cmd);

		return 0;
	} else {
		cmd->base.autoneg = 0;
		cmd->base.speed = (priv->force_speed_100) ?
+3 −1
Original line number Diff line number Diff line
@@ -477,7 +477,9 @@ static int bcmgenet_get_link_ksettings(struct net_device *dev,
	if (!priv->phydev)
		return -ENODEV;

	return phy_ethtool_ksettings_get(priv->phydev, cmd);
	phy_ethtool_ksettings_get(priv->phydev, cmd);

	return 0;
}

static int bcmgenet_set_link_ksettings(struct net_device *dev,
Loading