Commit 5513d08d authored Oct 01, 2017 by Xin Long Committed by David S. Miller Oct 01, 2017

ip_gre: check packet length and mtu correctly in erspan_xmit



As a ARPHRD_ETHER device, skb->len in erspan_xmit is the length
of the whole ether packet. So before checking if a packet size
exceeds the mtu, skb->len should subtract dev->hard_header_len.

Otherwise, all packets with max size according to mtu would be
trimmed to be truncated packet.

Fixes: 84e54fe0 ("gre: introduce native tunnel support for ERSPAN")
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 935a9749

net/ipv4/ip_gre.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -731,7 +731,7 @@ static netdev_tx_t erspan_xmit(struct sk_buff *skb,
		if (skb_cow_head(skb, dev->needed_headroom))
		goto free_skb;

		if (skb->len > dev->mtu) {
		if (skb->len - dev->hard_header_len > dev->mtu) {
		pskb_trim(skb, dev->mtu);
		truncate = true;
		}