Commit 54fd11fe authored Jun 25, 2016 by Peter Jones Committed by Ingo Molnar Jun 27, 2016

efi: Document #define FOO_PROTOCOL_GUID layout



Add a comment documenting why EFI GUIDs are laid out like they are.

Ideally I'd like to change all the ", " to "," too, but right now the
format is such that checkpatch won't complain with new ones, and staring
at checkpatch didn't get me anywhere towards making that work.

Signed-off-by: Peter Jones <pjones@redhat.com>
Signed-off-by: Matt Fleming <matt@codeblueprint.co.uk>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Joe Perches <joe@perches.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-efi@vger.kernel.org
Link: http://lkml.kernel.org/r/1466839230-12781-3-git-send-email-matt@codeblueprint.co.uk


Signed-off-by: Ingo Molnar <mingo@kernel.org>

parent 5356c327

include/linux/efi.h

+16 −1

Original line number	Diff line number	Diff line
		@@ -537,6 +537,21 @@ void efi_native_runtime_setup(void);

		/*
		* EFI Configuration Table and GUID definitions
		*
		* These should be formatted roughly like the ones in the UEFI SPEC has
		* them. It makes them easier to grep for, and they look the same when
		* you're staring at them. Here's the guide:
		*
		* GUID: 12345678-1234-1234-1234-123456789012
		* Spec:
		* #define EFI_SOME_PROTOCOL_GUID \
		* {0x12345678,0x1234,0x1234,\
		* {0x12,0x34,0x12,0x34,0x56,0x78,0x90,0x12}}
		* Here:
		* #define SOME_PROTOCOL_GUID \
		* EFI_GUID(0x12345678, 0x1234, 0x1234, \
		* 0x12, 0x34, 0x12, 0x34, 0x56, 0x78, 0x90, 0x12)
		* ^ tab ^tab ^ space
		*/
		#define NULL_GUID \
		EFI_GUID(0x00000000, 0x0000, 0x0000, \