Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 541ce98c authored by J. Bruce Fields's avatar J. Bruce Fields
Browse files

nfsd: don't leak dentry count on mnt_want_write failure 



The exit cleanup isn't quite right here.

Signed-off-by: default avatarJ. Bruce Fields <bfields@redhat.com>
parent 1bae4ce2

fs/nfsd/vfs.c

+6 −6
Original line number Diff line number Diff line
@@ -1812,22 +1812,22 @@ nfsd_unlink(struct svc_rqst *rqstp, struct svc_fh *fhp, int type, 


	host_err = mnt_want_write(fhp->fh_export->ex_path.mnt);

	if (host_err)

		goto out_nfserr;

		goto out_put;



	host_err = nfsd_break_lease(rdentry->d_inode);

	if (host_err)

		goto out_put;

		goto out_drop_write;

	if (type != S_IFDIR)

		host_err = vfs_unlink(dirp, rdentry);

	else

		host_err = vfs_rmdir(dirp, rdentry);

out_put:

	dput(rdentry);



	if (!host_err)

		host_err = commit_metadata(fhp);



out_drop_write:

	mnt_drop_write(fhp->fh_export->ex_path.mnt);

out_put:

	dput(rdentry);



out_nfserr:

	err = nfserrno(host_err);

out: