Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 53e13ee0 authored by James Smart's avatar James Smart Committed by Martin K. Petersen
Browse files

scsi: lpfc: Correct MDS diag and nvmet configuration 



A recent change added some MDS processing in the lpfc_drain_txq routine
that relies on the fcp_wq being allocated. For nvmet operation the fcp_wq
is not allocated because it can only be an nvme-target.  When the original
MDS support was added LS_MDS_LOOPBACK was defined wrong, (0x16) it should
have been 0x10 (decimal value used for hex setting). This incorrect value
allowed MDS_LOOPBACK to be set simultaneously with LS_NPIV_FAB_SUPPORTED,
causing the driver to crash when it accesses the non-existent fcp_wq.

Correct the bad value setting for LS_MDS_LOOPBACK.

Fixes: 	ae9e28f3  ("lpfc: Add MDS Diagnostic support.")
Cc: <stable@vger.kernel.org> # v4.12+
Signed-off-by: default avatarDick Kennedy <dick.kennedy@broadcom.com>
Signed-off-by: default avatarJames Smart <james.smart@broadcom.com>
Tested-by: default avatarEwan D. Milne <emilne@redhat.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 9abd9990

drivers/scsi/lpfc/lpfc.h

+1 −1
Original line number Diff line number Diff line
@@ -672,7 +672,7 @@ struct lpfc_hba { 
#define LS_NPIV_FAB_SUPPORTED 0x2	/* Fabric supports NPIV */

#define LS_IGNORE_ERATT       0x4	/* intr handler should ignore ERATT */

#define LS_MDS_LINK_DOWN      0x8	/* MDS Diagnostics Link Down */

#define LS_MDS_LOOPBACK      0x16	/* MDS Diagnostics Link Up (Loopback) */

#define LS_MDS_LOOPBACK      0x10	/* MDS Diagnostics Link Up (Loopback) */



	uint32_t hba_flag;	/* hba generic flags */

#define HBA_ERATT_HANDLED	0x1 /* This flag is set when eratt handled */