Commit 537f4146 authored Mar 06, 2018 by Arvind Yadav Committed by Tejun Heo Mar 13, 2018

workqueue: use put_device() instead of kfree()



Never directly free @dev after calling device_register(), even
if it returned an error! Always use put_device() to give up the
reference initialized in this function instead.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Tejun Heo <tj@kernel.org>

parent fc6eabbb

kernel/workqueue.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -5337,7 +5337,7 @@ int workqueue_sysfs_register(struct workqueue_struct *wq)

		ret = device_register(&wq_dev->dev);
		if (ret) {
		kfree(wq_dev);
		put_device(&wq_dev->dev);
		wq->wq_dev = NULL;
		return ret;
		}